-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x): Correct flap/slats positions #8651
Open
flogross89
wants to merge
15
commits into
flybywiresim:master
Choose a base branch
from
flogross89:fix-a380x-flaps-positions
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(a380x): Correct flap/slats positions #8651
flogross89
wants to merge
15
commits into
flybywiresim:master
from
flogross89:fix-a380x-flaps-positions
+662
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flogross89
added
Not Ready For Testing
Not ready for testing as still being discussed or developed.
Not Ready For Review
Still draft but needs a GitHub build
QA A380 Only
QA only for A380 required
A380X
Related to the A380X aircraft
labels
May 10, 2024
flogross89
force-pushed
the
fix-a380x-flaps-positions
branch
3 times, most recently
from
May 12, 2024 02:03
9064aa9
to
9c59c77
Compare
flogross89
removed
Not Ready For Testing
Not ready for testing as still being discussed or developed.
Not Ready For Review
Still draft but needs a GitHub build
labels
May 12, 2024
tracernz
requested changes
May 15, 2024
fbw-common/src/wasm/systems/systems/src/simulation/update_context.rs
Outdated
Show resolved
Hide resolved
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🔴 Code Review: In progress
May 15, 2024
(cherry picked from commit bf94a44)
flogross89
force-pushed
the
fix-a380x-flaps-positions
branch
from
May 25, 2024 23:23
826f3be
to
5877d39
Compare
@tracernz Reworked some bits, your comments should now be addressed |
tracernz
reviewed
May 26, 2024
fbw-a380x/src/wasm/systems/a380_systems/src/hydraulic/flaps_computer.rs
Outdated
Show resolved
Hide resolved
Gurgel100
reviewed
Jun 1, 2024
fn surface_movement_required(demanded_angle: Angle, feedback_angle: Angle) -> bool { | ||
(demanded_angle - feedback_angle).get::<degree>().abs() > Self::EQUAL_ANGLE_DELTA_DEGREE | ||
} | ||
|
||
fn angle_of_attack(&self, adirs: &impl AdirsMeasurementOutputs) -> Option<Angle> { | ||
[1, 2, 3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a TODO
comment here to indicate that this is not the correct logic yet.
vertical_speed: Arinc429Word::new(Velocity::default(), SignStatus::FailureWarning), | ||
altitude: Arinc429Word::new(Length::default(), SignStatus::FailureWarning), | ||
angle_of_attack: Arinc429Word::new( | ||
Angle::new::<degree>(0.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Angle::new::<degree>(0.0), | |
Angle::default(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A380X only, no QA needed.
Summary of Changes
This should be an improvement to the current SFCC implementation for the A380X.
In scope:
Out of scope:
Screenshots (if necessary)
References
Additional context
No appropriate references for A380 FPPU, hence it's assumed the same FPPU as in the A320 is used.
Resulting FPPU angles:
Discord username (if different from GitHub): floridude
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.