Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved expedited presets with quick ADIRS/APU/ENG start/stop #8581

Open
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Mar 23, 2024

Summary of Changes

Improve the expedited quick Aircraft Preset loading with making ADIRS/APU/ENG starting and stopping instantly.

Major changes

  • changes to ADIRS, APU, ENG, flaps/slats to allow a quick mode for very fast or instant startup and shutdown
  • Improvements to the expediated mode to leverage the quick mode - e.g. new step types
  • refactor the configuration to use a static XML file sitting in the aircraft package to allow future modding of presets

Additional changes:

  • fixing and improving the imbalance calculation for the A32NX fadec
  • Changed two wrongly named LVars (missing prefix):
    • AIRLINER_CRUISE_ALTITUDE ==> A32NX_AIRLINER_CRUISE_ALTITUDE
    • AIRLINER_TO_FLEX_TEMP ==> A32NX_AIRLINER_TO_FLEX_TEMP

Discord username (if different from GitHub): cdr_maverick

Screenshots / Video

2024-04-14_16h06_15.mp4

Testing instructions

A32NX:

Test all possible combinations of presets and presets sequences.
Test expedited or normal speed - even mix or change while loading
Regression Test and check normal operation without using presets and ensure this has not regressed in any way.

Check:

  • presets must load without hanging (hanging means the xml config is not correct)
  • any intermittent error and alarms that comes up goes away after a short time without manual interaction
  • no errors after a preset is loaded
  • no unusual state of the aircraft after a preset is loaded - example flaps/slats not retracted/extended
  • check if the state of the cockpit for each preset makes sense
    • these are roughly done along the SOP but not exactly as this wouldn't make sense
    • if you think a setting/step is incorrect in general or for a certain preset then report this - but this is not an error and does
      not fail QA
    • the steps are easily changed based on user and pilot feedback

Try to break it :D

Also check for regressions - there have been some changes to the ADIRS, APU, FADEC, flaps/slats code to make these instant or near-instant. So a full flight is recommended where these systems are also monitored/checked for any issues.

A380X:
Same but with less priority

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@frankkopp frankkopp self-assigned this Mar 23, 2024
@frankkopp frankkopp added the Not Ready For Review Still draft but needs a GitHub build label Mar 24, 2024
@frankkopp frankkopp marked this pull request as ready for review March 24, 2024 14:49
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Mar 24, 2024
@frankkopp frankkopp force-pushed the presets-expedite-fadec-apu branch 8 times, most recently from 85e3373 to 5a9dab3 Compare April 2, 2024 14:36
@frankkopp frankkopp force-pushed the presets-expedite-fadec-apu branch 4 times, most recently from 8545e2d to 460f6c8 Compare April 13, 2024 16:30
@frankkopp frankkopp requested review from 2hwk and tracernz April 14, 2024 13:44
@frankkopp frankkopp force-pushed the presets-expedite-fadec-apu branch 3 times, most recently from 52e635c to 1d4c7f0 Compare April 19, 2024 15:09
@frankkopp frankkopp added Needs Code Review and removed Not Ready For Review Still draft but needs a GitHub build labels Apr 19, 2024
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🔴 Code Review: In progress Apr 20, 2024
@frankkopp frankkopp requested a review from 2hwk April 21, 2024 11:09
@frankkopp
Copy link
Member Author

I have refactored this to use another XML library as there was a strange issue with the previously used one which skipped one XML section for no apparent reasons when using preset 1 directly after loading into sim (either on gate or runway).
The issue is fixed with using the other xml library (tinyxml2) - although this has a worse API than the previous pugixml it at least works without any issues.

I could not reproduce the "hot air" issue any more a believe this to be fixed.

@2hwk if you have time I would appreciate another test - thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Quality Assurance
🟣 QA Team Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

None yet

7 participants