-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved expedited presets with quick ADIRS/APU/ENG start/stop #8581
base: master
Are you sure you want to change the base?
feat: Improved expedited presets with quick ADIRS/APU/ENG start/stop #8581
Conversation
fbw-common/src/wasm/systems/systems/src/apu/electronic_control_box.rs
Outdated
Show resolved
Hide resolved
85e3373
to
5a9dab3
Compare
8545e2d
to
460f6c8
Compare
52e635c
to
1d4c7f0
Compare
.../html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/FMC/A32NX_FMCMainDisplay.js
Show resolved
Hide resolved
1d4c7f0
to
4d11d8b
Compare
…gacy LVars without prefix
…h of vars - code now checks if prefix is already present
d2c91d7
to
5b945f2
Compare
I have refactored this to use another XML library as there was a strange issue with the previously used one which skipped one XML section for no apparent reasons when using preset 1 directly after loading into sim (either on gate or runway). I could not reproduce the "hot air" issue any more a believe this to be fixed. @2hwk if you have time I would appreciate another test - thanks in advance. |
Summary of Changes
Improve the expedited quick Aircraft Preset loading with making ADIRS/APU/ENG starting and stopping instantly.
Major changes
Additional changes:
Discord username (if different from GitHub): cdr_maverick
Screenshots / Video
2024-04-14_16h06_15.mp4
Testing instructions
A32NX:
Test all possible combinations of presets and presets sequences.
Test expedited or normal speed - even mix or change while loading
Regression Test and check normal operation without using presets and ensure this has not regressed in any way.
Check:
not fail QA
Try to break it :D
Also check for regressions - there have been some changes to the ADIRS, APU, FADEC, flaps/slats code to make these instant or near-instant. So a full flight is recommended where these systems are also monitored/checked for any issues.
A380X:
Same but with less priority
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.