Fix text button example in a11y assessment app #148247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
a: text input
| testWidgets('text button must not contain "button" in their text', (WidgetTester tester) async { | ||
| await pumpsUseCase(tester, TextButtonUseCase()); | ||
| final List<Text> texts = tester.widgetList<Text>( | ||
| find.descendant(of: find.byType(TextButton), matching: find.byType(Text)), |
There was a problem hiding this comment.
You could get rid of the loop by using find.textContaining
|
closing this since this pr is closer #148905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/317125569
text button should not have "button" in the text, it will confuse user as it button will be announced twice
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.