Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for test suite import prefix value #148244

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented May 13, 2024

Addresses a TODO from #143170 (comment). This mirrors the change in package:test here: dart-lang/test#2226.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 13, 2024
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenzieschmoll kenzieschmoll changed the title Add test coverage for test library import prefix value Add test coverage for test suite import prefix value May 13, 2024
@kenzieschmoll
Copy link
Member Author

Will hold off on landing this until the discussion at #143170 (comment) is resolved.

@kenzieschmoll kenzieschmoll marked this pull request as draft May 14, 2024 23:15
@kenzieschmoll kenzieschmoll marked this pull request as draft May 14, 2024 23:15
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants