Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the second TextFormField to trigger onTapOutside #148206

Merged
merged 7 commits into from
May 22, 2024
Merged

Fix the second TextFormField to trigger onTapOutside #148206

merged 7 commits into from
May 22, 2024
+365 −1

Conversation

wyqlxf
Copy link
Contributor

@wyqlxf wyqlxf commented May 13, 2024

This PR attempts to fix #127597

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 13, 2024
@wyqlxf wyqlxf force-pushed the fix_127597 branch 3 times, most recently from 2f3dd00 to 5ff1576 Compare May 15, 2024 03:29
@Piinks
Copy link
Contributor

Piinks commented May 15, 2024

Hey @wyqlxf is this implementing the suggestion in #148112 (comment)?

@wyqlxf
Copy link
Contributor Author

wyqlxf commented May 15, 2024

Hey @wyqlxf is this implementing the suggestion in #148112 (comment)?

Yes, this is in response to the suggestion (comment) in execution #148112, Provide a separate click area groupId object for each text field, Thank you very much to @gspencergoog for the suggestion.

@wyqlxf wyqlxf force-pushed the fix_127597 branch 7 times, most recently from ac84fb0 to 53a8255 Compare May 17, 2024 04:19
@wyqlxf wyqlxf requested a review from navaronbracke May 17, 2024 05:33
navaronbracke
navaronbracke reviewed May 17, 2024
View reviewed changes
packages/flutter/lib/src/material/text_form_field.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/text_field.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/editable_text.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/editable_text.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/editable_text.dart Outdated Show resolved Hide resolved
packages/flutter/test/widgets/editable_text_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/widgets/editable_text_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/widgets/editable_text_test.dart Outdated Show resolved Hide resolved
@github-actions github-actions bot added the f: cupertino flutter/packages/flutter/cupertino repository label May 17, 2024
@wyqlxf wyqlxf requested a review from navaronbracke May 17, 2024 22:10
gspencergoog
gspencergoog approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for fixing this!

@wyqlxf wyqlxf requested a review from gspencergoog May 18, 2024 14:08
justinmc
justinmc approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits 👍

And I have one more nit about the test organization for you. It feels backwards to me. I would think that the tests in editable_text_test that just expect that groupId is set would be on TextField, TextFormField, and CupertinoTextField, expecting that they have passed the groupId down to their EditableTexts. Similarly, I would do the test that you currently have on CupertinoTextField and TextFormField in editable_text_test instead, so that the functionality is tested once there.

packages/flutter/lib/src/widgets/editable_text.dart Outdated Show resolved Hide resolved
packages/flutter/test/cupertino/text_field_test.dart Show resolved Hide resolved
packages/flutter/test/material/text_form_field_test.dart Show resolved Hide resolved
@wyqlxf wyqlxf force-pushed the fix_127597 branch 4 times, most recently from 77d1661 to be1e8a4 Compare May 22, 2024 07:18
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@auto-submit auto-submit bot merged commit 9acbc1d into flutter:master May 22, 2024
73 checks passed
Renzo-Olivares added a commit that referenced this pull request May 22, 2024
@Renzo-Olivares
Revert "Fix the second TextFormField to trigger onTapOutside (#148206)"
600121e 
This reverts commit 9acbc1d.
@Renzo-Olivares Renzo-Olivares mentioned this pull request May 22, 2024
Merged
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 23, 2024
@hello-coder-xu
Merge branch 'fix/_floatingActionButtonVisibilityValue-update' of htt…
396e78f 
…ps://github.com/hello-coder-xu/flutter into fix/_floatingActionButtonVisibilityValue-update

* 'fix/_floatingActionButtonVisibilityValue-update' of https://github.com/hello-coder-xu/flutter:
  fix: update _floatingActionButtonVisibility only if floatingActionButton is not null
  [wiki migration] Remaining pages under docs/about/ (flutter#148782)
  Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter#148883)
  Fix the second TextFormField to trigger onTapOutside (flutter#148206)
  Try removing robolectric from `integration_test` tests (flutter#148803)
  Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter#147160)
  [wiki migration] Tool team pages (flutter#148779)
  Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter#148819)
  [native_assets] Add support for link hooks (flutter#148474)
  Roll Packages from ba19b247d0ba to 65254411e677 (12 revisions) (flutter#148864)
  Update tokens to 4.0.0 (flutter#148789)
  Move Linux web_long_running_tests_2_5 to bringup (flutter#148854)
  `CupertinoDialogRoute` leak fix (flutter#148774)
  Marks Windows plugin_test to be flaky (flutter#148835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
9acbc1d4a Fix the second TextFormField to trigger onTapOutside (flutt…
7051e4d 
…er/flutter#148206)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
9acbc1d4a Fix the second TextFormField to trigger onTapOutside (flutt…
92ad9a5 
…er/flutter#148206)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
9acbc1d4a Fix the second TextFormField to trigger onTapOutside (flutt…
1de4653 
…er/flutter#148206)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
Roll Flutter from 73bf206f35e7 to 8d955cdd644e (24 revisions) (#6786)
1008d9e 
flutter/flutter@73bf206...8d955cd

2024-05-23 nate.w5687@gmail.com Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 matej.knopp@gmail.com [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 104349824+huycozy@users.noreply.github.com Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 32538273+ValentinVignal@users.noreply.github.com Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 sokolovskyi.konstantin@gmail.com Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 kevinjchisholm@google.com 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 helinx@google.com Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 rmolivares@renzo-olivares.dev Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 katelovett@google.com [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 34871572+gmackall@users.noreply.github.com Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 victoreronmosele@gmail.com Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 katelovett@google.com [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 dacoharkes@google.com [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 engine-flutter-autoroll@skia.org Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864)
2024-05-22 36861262+QuncCccccc@users.noreply.github.com Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 zanderso@users.noreply.github.com Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navaronbracke navaronbracke Awaiting requested review from navaronbracke

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

@justinmc justinmc Awaiting requested review from justinmc

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After inputting text into a textFormField tapping into a second TextFormField does not trigger onTapOutside
5 participants
@wyqlxf @Piinks @justinmc @gspencergoog @navaronbracke