Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageController: added default [duration] and [curve] values to animateToPage, nextPage and previousPage methods #148197

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KristijanZic
Copy link
Contributor

@KristijanZic KristijanZic commented May 12, 2024

This PR adds default [duration] and [curve] parameters to the animateToPage, nextPage and previousPage methods in the PageController

This PR addresses the issue: #37568

This change doesn't require changing any tests.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…s) for animateToPage, nextPage and previousPage methods
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label May 12, 2024
@goderbauer
Copy link
Member

@KristijanZic Thank you for the contribution. To make sure that this functionality doesn't regress could you please add a test (see previous message of the bot)? Also, it looks like the analyzer check is unhappy. Could you please take a look? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants