-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TV as the default profile for BuildTpkCommand #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be rebased according to the merge of #537. |
swift-kim
reviewed
May 14, 2024
swift-kim
reviewed
May 14, 2024
Add -ptizen to the --device-profile option of the build command and set -ptv as the default. flutter-tizen#537 (comment) Accordingly, clean up the logic of getFlutterRootstrap().
rebased |
swift-kim
reviewed
May 17, 2024
swift-kim
reviewed
May 21, 2024
JSUYA
changed the title
Add tizen profile in build command
Set default of --device-profile to tv
May 21, 2024
swift-kim
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there. Thanks for cleaning up.
swift-kim
changed the title
Set default of --device-profile to tv
Set TV as the default profile for BuildTpkCommand
May 21, 2024
swift-kim
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default of --device-profile to tv.
And #537 (comment)
accordingly, clean up the logic of getFlutterRootstrap().