Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TV as the default profile for BuildTpkCommand #543

Merged
merged 9 commits into from
May 23, 2024

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented May 13, 2024

Set default of --device-profile to tv.
And #537 (comment)
accordingly, clean up the logic of getFlutterRootstrap().

version type arch target profile name use tizen rootstrap alternative rootstrap
6.0/6.5/7.0 device arm iot-headed common iot-headed-x.x-device.cor
6.0/6.5/7.0 device arm iot-headless common iot-headless-x.x-device.core
6.0/6.5/7.0 devcie64 arm64 iot-headed common iot-headed-x.x-device64.core
6.0/6.5/7.0 device arm tv tv-samsung tv-samsung-x.x-device.core iot-headed-x.x-device.core
6.0/6.5/7.0 emulator x86 tv tv-samsung - mobile-x.x-emulator.core
6.0/6.5/7.0 device arm mobile mobile mobile-x.x-device.core
6.0/6.5/7.0 emulator x86 mobile mobile mobile-x.x-emulator.core
8.0 device arm tizen common tizen-8.0-device.core
8.0 emulator x86 tizen common tizen-8.0-emulator.core
8.0 device64 arm64 tizen common tizen-8.0-device64.core
8.0 emulator x86 tv tv-samsung - tizen-8.0-emulator.core

@JSUYA
Copy link
Member Author

JSUYA commented May 13, 2024

It will be rebased according to the merge of #537.

@JSUYA JSUYA marked this pull request as draft May 13, 2024 08:30
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
lib/tizen_sdk.dart Show resolved Hide resolved
lib/tizen_builder.dart Outdated Show resolved Hide resolved
lib/commands/build.dart Outdated Show resolved Hide resolved
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
JSUYA added 4 commits May 17, 2024 15:19
Add -ptizen to the --device-profile option of the build command
and set -ptv as the default.
flutter-tizen#537 (comment)
Accordingly, clean up the logic of getFlutterRootstrap().
@JSUYA
Copy link
Member Author

JSUYA commented May 17, 2024

rebased

@JSUYA JSUYA marked this pull request as ready for review May 17, 2024 06:57
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
lib/tizen_sdk.dart Show resolved Hide resolved
lib/commands/build.dart Outdated Show resolved Hide resolved
lib/commands/build.dart Outdated Show resolved Hide resolved
lib/tizen_doctor.dart Outdated Show resolved Hide resolved
@JSUYA JSUYA changed the title Add tizen profile in build command Set default of --device-profile to tv May 21, 2024
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there. Thanks for cleaning up.

lib/tizen_sdk.dart Outdated Show resolved Hide resolved
@swift-kim swift-kim changed the title Set default of --device-profile to tv Set TV as the default profile for BuildTpkCommand May 21, 2024
lib/tizen_sdk.dart Show resolved Hide resolved
lib/tizen_sdk.dart Outdated Show resolved Hide resolved
@JSUYA JSUYA merged commit fc554a7 into flutter-tizen:master May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants