-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added BY25D16 - Boya Microelectronics #96
base: master
Are you sure you want to change the base?
Conversation
Change-Id: Ibe24c3dc52c413ce9422deb9045773dfd042f9e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch and also for providing a link ot the datasheet - that helps a lot!
There are a couple minor issues. For the commit message, please follow the template on https://www.flashrom.org/Development_Guidelines#Commit_message.
.block_erase = spi_block_erase_c7, | ||
} | ||
}, | ||
.printlock = spi_prettyprint_status_register_at25df, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The block protect bits do not seem to match the at25df.
If there's not another good match in spi25_statusreg.c, you can add one or just use spi_prettyprint_status_register_hex().
} | ||
}, | ||
.printlock = spi_prettyprint_status_register_at25df, | ||
.unlock = spi_disable_blockprotect_at2x_global_unprotect, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems spi_disable_blockprotect_bp2_srwd would be a better choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for my late reply.
You may be right but I broke the flash chip after some soldering action, so I cannot test it again.
I'll change the function to spi_disable_blockprotect_bp2_srwd and try it again when I got another BY25D16 chip.
Change-Id: Ibe24c3dc52c413ce9422deb9045773dfd042f9e0
Added the BY25D16 SPI flash memory in " flashchips.c" and " flashchips.h" and tried it on a FT2232H adapter.