Update ch341a_spi.c #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible typo so changed libusb_set_debug to libusb_set_option.
i-c-o-n
reviewed
Feb 3, 2019
| @@ -434,7 +434,7 @@ int ch341a_spi_init(void) | |||
|
|
|||
| /* Enable information, warning, and error messages (only). */ | |||
| #if LIBUSB_API_VERSION < 0x01000106 | |||
There was a problem hiding this comment.
Are you sure this condition is true for your version of libusb?
There was a problem hiding this comment.
I'm using flashrom-9.9+r1954. On line 447 of ch341a_spi.c there is a call to libusb_set_debug that causes warnings. I can see in more recent versions of flashrom that you're checking the LIBUSB_API_VERSION so obviously this patch is only useful for older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible typo so changed libusb_set_debug to libusb_set_option.