-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add W25Q16JVNIM support #178
base: master
Are you sure you want to change the base?
Conversation
Hello @jogolden Could you please add your signoff to the commit message? Are you familiar with the gerrit review process? If not I can move it there. |
Signed-off-by: John Fitzgerald <cloverleafswag3@gmail.com>
Signed-off-by: John Fitzgerald <cloverleafswag3@gmail.com>
Is this okay? |
Hi @jogolden Well I still do not see the signoff in your commit message, so here is what I recommend to do: Run git commit -a --amend in your repo. Signed-off-by: John Fitzgerald jofitz@protonmail.com Then I will take care of moving this change to gerrit and get it reviewed and merged there. |
Signed-off-by: John Fitzgerald jofitz@protonmail.com
Damn this has turned into a mess, Im sorry |
No worries, git is hard sometimes. I only need a signoff in a commit message for formal reasons. |
The PlayStation 5 has a W25Q16JVNIM chip from winbond.