Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W25Q16JVNIM support #178

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add W25Q16JVNIM support #178

wants to merge 5 commits into from

Conversation

jogolden
Copy link

@jogolden jogolden commented Dec 6, 2020

The PlayStation 5 has a W25Q16JVNIM chip from winbond.

@jogolden
Copy link
Author

jogolden commented Dec 6, 2020

@martonmiklos
Copy link
Contributor

Hello @jogolden

Could you please add your signoff to the commit message?
https://flashrom.org/Development_Guidelines#Sign-off_Procedure

Are you familiar with the gerrit review process? If not I can move it there.

Signed-off-by: John Fitzgerald <cloverleafswag3@gmail.com>
Signed-off-by: John Fitzgerald <cloverleafswag3@gmail.com>
@jogolden
Copy link
Author

Is this okay?

@martonmiklos
Copy link
Contributor

Hi @jogolden

Well I still do not see the signoff in your commit message, so here is what I recommend to do:

Run git commit -a --amend in your repo.
This will open up the commit message editor, paste the following to the end of the message:

Signed-off-by: John Fitzgerald jofitz@protonmail.com
Save the commit message.
Push the modified message with git push --force

Then I will take care of moving this change to gerrit and get it reviewed and merged there.

Signed-off-by: John Fitzgerald jofitz@protonmail.com
@jogolden
Copy link
Author

Damn this has turned into a mess, Im sorry

@martonmiklos
Copy link
Contributor

No worries, git is hard sometimes.
I can squash it befire moving to gerrit.

I only need a signoff in a commit message for formal reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants