Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for BY25Q128AS - BoyaMicro Electronics #161

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cecada
Copy link
Contributor

@cecada cecada commented Aug 1, 2020

Sorry for the false start earlier, noticed a potential error, fixed it. Retested under several conditions, seems to work great.
Added support for BY25Q128AS - BoyaMicro Electronics

Signed-off-by: Jack Olsen omegasec@tutanota.com

Tested and it works. Chip BY25Q128AS / BoyaMicro
Add support for chip BY25Q128AS / Boya Micro
Added support for BY25Q128AS - BoyaMicro Electronics - tested and verified
Copy link
Contributor

@dhendrix dhendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. In addition to the comments in flashchips.c, please add your sign-off to the commit message as per https://flashrom.org/Development_Guidelines#Sign-off_Procedure

flashchips.c Outdated Show resolved Hide resolved
flashchips.c Outdated Show resolved Hide resolved
flashchips.c Outdated Show resolved Hide resolved
flashchips.c Outdated Show resolved Hide resolved
@cecada
Copy link
Contributor Author

cecada commented Aug 5, 2020

Thanks for the PR. In addition to the comments in flashchips.c, please add your sign-off to the commit message as per https://flashrom.org/Development_Guidelines#Sign-off_Procedure

Added signature line to top level comment. Let me know if this works.

@Th3Fanbus
Copy link
Member

The GitHub repo is a mirror from Gerrit, where we review and submit patches. It's at https://review.coreboot.org and you can use GitHub as a login method. We use the same infrastructure as coreboot, so you can use the same instructions: https://doc.coreboot.org/tutorial/part2.html

If you cloned the repo from GitHub, you would need to update the remote git repository's location. In case you get an error when running git push, try with git push origin HEAD:refs/for/master instead.

@cecada
Copy link
Contributor Author

cecada commented Aug 9, 2020

The GitHub repo is a mirror from Gerrit, where we review and submit patches. It's at https://review.coreboot.org and you can use GitHub as a login method. We use the same infrastructure as coreboot, so you can use the same instructions: https://doc.coreboot.org/tutorial/part2.html

If you cloned the repo from GitHub, you would need to update the remote git repository's location. In case you get an error when running git push, try with git push origin HEAD:refs/for/master instead.

Done.

Copy link
Contributor Author

@cecada cecada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants