meson fixes #154
Open
meson fixes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when passing meson -Dconfig_rayer_spi=false , compilation fails as the proper headers and defines are not available. Added need_raw_access based on whichever files include hwaccess.h Signed-off-by: Rosen Penev <rosenp@gmail.com>
Fixes meson error: meson.build:304:3: ERROR: Unknown variable "config_bitbang_spi". Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
ping @felixsinger |
|
Is there any reason why you don't upload them to Gerrit yourself? |
|
I don't use gerrit. |
|
Yeah, why? What's the reason for this? Like don't you know how to setup your local repository or do you just don't want to create another account somewhere? In the latter case, you can choose between many OAuth providers, including GItHub, and you also can use OpenID if you prefer that. https://review.coreboot.org/login |
|
latter case. Maybe the LLVM workflow left a bad taste in my mouth (Phabricator). git send-mail is simple enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally flashrom is built with all options enabled. But it starts to go wrong when several options are disabled. This is the case in the OpenWrt package where 4 separate packages are provided with differing functionality. (flashrom, -pci, -usb, -spi).