udelay.c: Enable providing delay calibration value through CLI #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements --delay option to retrieve and provide the calibration
loop delay through the command line. The delay calibration procedure can take
up to few seconds, which adds up when executed a number of times consecutively.
Therefore, this provides a means to execute it only once, and then re-use the
calibrated value on subsequent runs. Also, it implements a sanity check,
expecting the value to land within 10% of the theoretical delay expectance,
otherwise it ignores the provided value and runs the calibration procedure
instead.
modified: cli_classic.c
modified: flashrom.8.tmpl
modified: programmer.h
modified: udelay.c
Change-Id: Iea2a7f62300663bc0a32ed4abced57c8c55c90c8
Signed-off-by: Hrvoje Cavrak <hrvoje@hrvoje.org>
martonmiklos
suggested changes
Mar 25, 2020
cli_classic.c
Outdated
Comment on lines
66
to
67
| " -d | --delay <value> set loop delay calibration manually\n" | ||
| " --delay get show loop delay calibration\n" |
There was a problem hiding this comment.
I would suggest to rename it since the delay is a bit too generic I think. loop-delay maybe? Also what is the unit of the delay?
But let's move to gerrit and other devs will comment on this I think too.
cli_classic.c
Outdated
| @@ -156,6 +159,7 @@ int main(int argc, char *argv[]) | |||
| {"help", 0, NULL, 'h'}, | |||
| {"version", 0, NULL, 'R'}, | |||
| {"output", 1, NULL, 'o'}, | |||
| {"delay", 1, NULL, 'd'}, | |||
There was a problem hiding this comment.
The 1, part indentation is misaligned.
udelay.c
Outdated
| @@ -221,6 +221,25 @@ void myusec_calibrate_delay(void) | |||
| msg_pinfo("OK.\n"); | |||
| } | |||
|
|
|||
| void set_external_calibration(unsigned long external_micro) { | |||
There was a problem hiding this comment.
The '{' should go to the next line
udelay.c
Outdated
| } | ||
| } | ||
|
|
||
| unsigned long get_calibration_value(void) { |
There was a problem hiding this comment.
The '{' should go to the next line
added 2 commits
March 25, 2020 17:58
|
Fixed, submitted through Gerrit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements --delay option to retrieve and provide the calibration
loop delay through the command line. The delay calibration procedure can take
up to few seconds, which adds up when executed a number of times consecutively.
Therefore, this provides a means to execute it only once, and then re-use the
calibrated value on subsequent runs. Also, it implements a sanity check,
expecting the value to land within 10% of the theoretical delay expectance,
otherwise it ignores the provided value and runs the calibration procedure
instead.
Change-Id: Iea2a7f62300663bc0a32ed4abced57c8c55c90c8
Signed-off-by: Hrvoje Cavrak hrvoje@hrvoje.org