Improve cross-compiling for Windows #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, we can cross-compile for Windows using mingw-w64. However, we wind up in a case where both OS_NAME=Darwin and IS_WIN=yes. This commit rearranges the checks in common.mk to check the latter first.
isuruf
reviewed
May 25, 2021
| ifeq ($(CC_VENDOR),gcc) | ||
| SHLIB_EXT := dll.a | ||
| else | ||
| SHLIB_EXT := lib | ||
| endif | ||
| else ifeq ($(OS_NAME),Darwin) |
There was a problem hiding this comment.
This is only partially related, but we should do the as IS_WIN here. (Set IS_DARWIN by checking for __APPLE__ macro)
There was a problem hiding this comment.
I'm not sure what you're suggesting. IS_WIN is checked, I just moved that check before checking OS_NAME. I don't think that having OS_NAME=Darwin is necessarily bad in this circumstance, and I was able to successfully create a .dll on my machine.
There was a problem hiding this comment.
I mean when cross compiling for macOS from Linux.
There was a problem hiding this comment.
Ah. I didn't even know such a thing was possible. I'll save that for another issue/PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes intended to fix whatever problems may exist for cross-compiling on Windows from Linux (incl. WSL) and macOS.