Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Deprecate TapDetector in favour of TapCallbacks #2886

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs: Deprecate TapDetector in favour of TapCallbacks #2886

wants to merge 2 commits into from

Conversation

luanpotter
Copy link
Member

Description

Deprecate TapDetector in favour of TapCallbacks

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as draft December 1, 2023 04:41
@luanpotter luanpotter mentioned this pull request Dec 1, 2023
Merged
6 tasks
spydon added a commit that referenced this pull request Dec 1, 2023
@luanpotter @spydon
docs: Update t-rex game to use TapCallbacks (#2888)
81930e2 
Update t-rex game to use `TapCallbacks` instead of `TapDetector`, in
anticipation of [deprecating the
latter](#2886).

Also update the term high score to avoid a dictionary entry.

Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@luanpotter