-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(firebase_messaging): Update example app & documentation for initializing Firebase app from top-level. #8061
base: master
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit f7a5e9d): https://flutter-firebase-docs--pr8061-russell-messaging-f-v7uc3sjd.web.app (expires Thu, 17 Feb 2022 14:35:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Decided to solve this at the root. I believe there are too many connections/writes at the same time to the SQL instance hence the error. Possibly need to cache Firebase or Firestore instance if initializing app from separate isolate. |
Closing as the issue appears to be resolved. |
@russellwheatley Is it resolved from the flutter firebase package itself? |
@deepak786 The issue is closed so I presumed it was resolved. Are you still experiencing the issue? |
@russellwheatley we are using the approach defined in this PR. So I want to know if we should continue with that or not. |
@deepak786 I'm not sure, I presumed the lack of responses to the issue, and that it was closed meant it had been resolved at the level of the SDK. I think I'd prefer to reopen the issue if it is still a problem. |
Hi @russellwheatley, Im getting same error message in Crashlytics today. I saw that you mentioned fixing it at the root where the SQL instance seemed to be overwhelm, is that still planned or do I have to implement the fix suggested by this PR? @Lyokone since you closed the issue could you give some information on the reason? With further investigation I found another crash log in Crashlytics.
From this error message it seems like we shouldn't be initializing two instances of Firebase (Assuming its creating a firestore instance under the hood). If we do so I think we need to set |
Hope making initapp a global will solve the originating issue: I reworked my app based on the Firebase Messaging Flutter example app, and with two initilizeApp calls I started seeing the referenced github issue... |
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
fixes #6087
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?