Add better error logging to perspective manager message handling #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still a draft @timkpaine ? |
|
@texodus its good to go but technically all this code will go away with the client/server overhaul. |
Merged
|
Thanks for the PR! I've cherry-picked this into #2623, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to debug a nasty issue which ended up being entirely due to some misuse of react. However, in the course of doing so, I noticed some server-side errors being swallowed. This PR adds a bit more verbose logging when client/server errors occur.
It will soon be obsolete due to the port to
rust.