-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Removed ContextMenuFlyoutItemViewModelBuilder #15299
Code Quality: Removed ContextMenuFlyoutItemViewModelBuilder #15299
Conversation
This is on my todo list to review |
Ready |
src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
{ | ||
/// <summary> | ||
/// Button type. | ||
/// </summary> | ||
Item, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's usually refered to as "menu item" as opposed to "button".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename back to Item
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…Model.cs Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
…0x5bfa/Files into 5bfa/CQ-ContextFlyoutItemModel2
Messed up. I have to redo everything |
I can't remember why I did change. |
Of course! And if it's easier, we can merge in stages. |
Summary
ContextMenuFlyoutItemType
toContextFlyoutItemType
ContextMenuFlyoutItemViewModelBuilder
ContextMenuFlyoutItemViewModel
toContextFlyoutItemModel
ContextFlyoutItemModel
ContextFlyoutItemModel
PR Checklist
Close Code Quality: Remove ContextMenuFlyoutItemViewModelBuilder #14761
Screenshots
None