Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Removed ContextMenuFlyoutItemViewModelBuilder #15299

Closed

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 4, 2024

Summary

  • ContextMenuFlyoutItemType to ContextFlyoutItemType
  • Removed ContextMenuFlyoutItemViewModelBuilder
  • ContextMenuFlyoutItemViewModel to ContextFlyoutItemModel
  • Added XML comments in ContextFlyoutItemModel
  • Added some constructors to adopt with IRichCommand in ContextFlyoutItemModel

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Close Code Quality: Remove ContextMenuFlyoutItemViewModelBuilder #14761
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Go to layout page
    2. Right click (check if shown correctly)
    3. Select item and right click (check again)
    4. Right click Sidebar item (again)
    5. Go to Home
    6. Right click Widget item (again)

Screenshots

None

@yaira2 yaira2 self-requested a review May 5, 2024 03:08
@yaira2
Copy link
Member

yaira2 commented May 12, 2024

This is on my todo list to review

@0x5bfa
Copy link
Member Author

0x5bfa commented May 28, 2024

Ready

{
/// <summary>
/// Button type.
/// </summary>
Item,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's usually refered to as "menu item" as opposed to "button".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename back to Item?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yaira2 yaira2 requested review from hishitetsu June 4, 2024 01:51
@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 6, 2024

Messed up. I have to redo everything

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 6, 2024

I can't remember why I did change.
Can I recreate a PR and publish step by step?

@yaira2
Copy link
Member

yaira2 commented Jun 6, 2024

I can't remember why I did change. Can I recreate a PR and publish step by step?

Of course! And if it's easier, we can merge in stages.

@yaira2 yaira2 closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Remove ContextMenuFlyoutItemViewModelBuilder
2 participants