Code Quality: Removed Vanara.PInvoke.Mpr & Vanara.PInvoke.DwmApi #15292
+132
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gave92 I'd like to request to review since I changed codes around the preview handler. The total amount of size of Vanara is about 4.12 MB, while DirectN has 4.85 MB. Do you think DirectN can be replaced with CsWin32? |
gave92
suggested changes
May 13, 2024
| { | ||
| return true; | ||
| } | ||
| else | ||
| { | ||
| await DialogDisplayHelper.ShowDialogAsync("NetworkFolderErrorDialogTitle".GetLocalizedResource(), connectionError.ToString().Split(":")[1].Trim()); | ||
| await DialogDisplayHelper.ShowDialogAsync("NetworkFolderErrorDialogTitle".GetLocalizedResource(), res.ToString()); |
There was a problem hiding this comment.
Any reason to remove the ".Split(":")[1].Trim()"?
There was a problem hiding this comment.
Found out in the first place this is not needed.
Files/src/Files.App/Strings/en-US/Resources.resw
Lines 2217 to 2219 in ea18185
src/Files.App/ViewModels/UserControls/Previews/ShellPreviewViewModel.cs
Outdated
Show resolved
Hide resolved
gave92
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.