Improve coverage of PR #300 #866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idubnori
commented
Aug 10, 2021
idubnori
commented
- Add test with precisePreview option
- Related to Add a new 'precisePreview' option #300 (comment)
Canvas context is translated by width/2, height/2 before applying transformations and should be translated back by the same values, not the rounded ones.
When true it takes rounding errors into account and makes the preview exactly match the cropped result
…recise-preview-option
fengyuanchen
force-pushed
the
main
branch
5 times, most recently
from
cb5ac44
to
aa96a51
Compare
fengyuanchen
force-pushed
the
main
branch
2 times, most recently
from
a367d75
to
3375ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.