Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cropper-selection): aspectRatio reactivity #1163

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

NamesMT
Copy link

@NamesMT NamesMT commented Apr 21, 2024

Reopen of #1161

Resolves #1124

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)
Maybe?, theorically if user allowed input to change the aspect-ratio multiple times before commiting an action, then previously the width/height is only recalculated once, but because it is now reactive, the width/height would recalculated and grow multiple times.
#1164 would improve the UX on this part where the selection area would not grow too much.

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
    It is referenced in commit body

You have tested in the following browsers: (Providing a detailed version will be better.)
Tested with playground

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

fengyuanchen added a commit that referenced this pull request May 4, 2024
…t-ratio`, `initial-aspect-ratio`, `initial-coverage`, and `precise` properties reactive

fix #1124, #1163, #1164, #1165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant