Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ali get source #1454

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Ali get source #1454

wants to merge 15 commits into from

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented May 16, 2024

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat temporarily deployed to Integration testing May 16, 2024 22:55 — with GitHub Actions Inactive
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.73%. Comparing base (ccb04d8) to head (a17cdd2).
Report is 1 commits behind head on main.

Files Patch % Lines
client/src/featureform/grpc_client.py 25.00% 6 Missing ⚠️
client/src/featureform/register.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   57.72%   57.73%           
=======================================
  Files         195      195           
  Lines       26057    26063    +6     
  Branches      853      855    +2     
=======================================
+ Hits        15042    15047    +5     
+ Misses       9395     9394    -1     
- Partials     1620     1622    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants