Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converts remaining unstructured errors to use fferr #1374

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

epps
Copy link
Contributor

@epps epps commented Mar 4, 2024

Description

This PR converts remaining unstructured errors to use fferr package.

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested a review from sdreyer March 4, 2024 18:46
@epps epps had a problem deploying to Integration testing March 4, 2024 18:46 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing March 7, 2024 19:55 — with GitHub Actions Failure
@sdreyer sdreyer temporarily deployed to Integration testing March 12, 2024 20:15 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.81%. Comparing base (6395449) to head (f44bc12).

Files Patch % Lines
provider/clickhouse.go 0.00% 3 Missing ⚠️
provider/k8s.go 0.00% 2 Missing ⚠️
filestore/filepath.go 0.00% 1 Missing ⚠️
provider/filestore.go 0.00% 1 Missing ⚠️
serving/serving.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1374   +/-   ##
=======================================
  Coverage   55.80%   55.81%           
=======================================
  Files         189      189           
  Lines       24721    24723    +2     
  Branches      833      833           
=======================================
+ Hits        13796    13799    +3     
- Misses       9392     9393    +1     
+ Partials     1533     1531    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdreyer sdreyer temporarily deployed to Integration testing March 14, 2024 00:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants