Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hdfs Utils] add uri param to filesystem get api #1219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bheroder
Copy link

@bheroder bheroder commented Sep 9, 2023

Description

when HDFS is configured with fs.defaultsFS pointing to blob storage, we are not able to give local path as source location in feature definition config. this is because hdfsutils.scala uses FileSystem.get(conf) API. instead using FileSystem.get(URI, conf) solves the problem where one can give source location as file:///xyz even though defaultFS points to blob.

Testing

manually tested using notebook session configured with fs.defaultFS= wasbs://xyz
FileSystem.get(conf).exists("file:///path") returns false
FileSystem.get(URI, conf).exists("file:///path") returns true

Does this PR introduce any user-facing changes?

  • [X ] No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@bheroder
Copy link
Author

bheroder commented Sep 9, 2023

cc @xiaoyongzhu

@bheroder
Copy link
Author

bheroder commented Sep 12, 2023

@windoze could you help with tagging the right reviewers ?

@bheroder
Copy link
Author

@jaymo001 @rakeshkashyap123 could you please review ? cc @windoze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant