Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add missing CI for feast-operator image builds #4184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented May 7, 2024

What this PR does / why we need it:

Missing CI related to #4145

This change will require that the following image repos are created (if they don't already exist) -

gcr.io/kf-feast/feast-operator
gcr.io/kf-feast/feature-server

Which issue(s) this PR fixes:

#4144

Signed-off-by: Tommy Hughes <tohughes@redhat.com>
@tchughesiv tchughesiv changed the title add missing CI for feast-operator image builds fix: add missing CI for feast-operator image builds May 7, 2024
@tchughesiv tchughesiv changed the title fix: add missing CI for feast-operator image builds fix: Add missing CI for feast-operator image builds May 7, 2024
@tchughesiv tchughesiv changed the title fix: Add missing CI for feast-operator image builds test: Add missing CI for feast-operator image builds May 7, 2024
@tchughesiv tchughesiv changed the title test: Add missing CI for feast-operator image builds ci: Add missing CI for feast-operator image builds May 7, 2024
@tchughesiv
Copy link
Contributor Author

tchughesiv commented May 8, 2024

@woop is this something you can help with? the creation of those repos that is.
or, maybe increased perms for @franciscojavierarceo or @jeremyary so they can handle it?

@woop
Copy link
Member

woop commented May 13, 2024

Checking this out right now.

@woop
Copy link
Member

woop commented May 13, 2024

Just to confirm, is there a reason we'd use kf-feast on GCR instead of dockerhub? Also, @franciscojavierarceo can you confirm what access you have already?

@tchughesiv
Copy link
Contributor Author

tchughesiv commented May 13, 2024

@woop its used in .github/workflows/master_only.yml, which is named "integration-tests-and-build". it appears to run upon PR merge into the master branch and is a way a ensure image builds/pushes are working prior to release.

@franciscojavierarceo
Copy link
Member

I have access to Dockerhub but not gcr

@woop
Copy link
Member

woop commented May 19, 2024

Hey @franciscojavierarceo you should have GCR access now if you check your GCP console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants