Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test images from training set #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmcker
Copy link

@mmcker mmcker commented Jan 29, 2023

The test images (downloaded at the beginning of the lesson) are sometimes re-downloaded and used in the training set. I have suggested a simple fix (discard the training image if it is the same size as the [resized] test image). There are better ways to do it (and probably more elegant ways to write the fix).

A better implementation may be to pull out a few of the 600 downloaded images, and use these as test images - but I thought this didn't fit in with the flow of the lesson as well.

This is the only lesson I have done - and love it - thanks for all the hard work.

A suggested exercise for students could include - how does the resnet18 model predict without the fine tuning? (Answer is very poorly!)

Exclude test images from training set
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant