Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple_oauth to 6.0.0-beta6 #843

Merged
merged 2 commits into from
May 9, 2024

Conversation

paul121
Copy link
Member

@paul121 paul121 commented May 8, 2024

Before we merge this I want to make sure my updated patch gets reviewed either by us or other simple_oauth maintainers. I found a new (minor) issue and slightly refactored the client validation logic in the process. The simple_oauth tests are all still passing and I feel confident in the changes but just something that should get more eyes on it.

https://www.drupal.org/project/simple_oauth/issues/3322325#comment-15586095

@mstenta
Copy link
Member

mstenta commented May 9, 2024

I gave this a quick look, and although I haven't followed this thread closely your changes and explanations make sense. Looking at the old patch and the new patch, and the differences between them, I don't see anything that concerns me about including the new patch in farmOS. We've been using the old one for over a year without any issue, and the new changes don't look like they are significantly different enough to cause issues. But I'm admittedly not an OAuth2 expert, so there may be cases I'm overlooking.

I personally think this looks safe to merge. 👍

@mstenta mstenta merged commit 196d696 into farmOS:3.x May 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants