Update to Drupal 10.2 #765
Conversation
|
This LGTM! Can I merge it? Or did you leave it in draft for a reason?
Interesting. Does this change also fix #625, perhaps? |
Nevermind, I don't think it fixes that issue, but removing the format is a good change because as we can see in those screenshots it is wrong most of the time anyway. |
|
@mstenta and I chatted about this today and we feel pretty good. Should be fine to merge this and we could tag 3.0.0 stable soon after. If there are any issues, they can be fixed as we go. |
See https://www.drupal.org/node/3385058 Fix: Call to deprecated method formatExample() of class Drupal\Core\Datetime\Element\Datetime: in drupal:10.2.0 and is removed from drupal:11.0.0. There is no replacement.
There was a problem hiding this comment.
LGTM!
Also, 10.2.1 was released today, so I added a commit to update to that. And I found the 10.2.x patch you made here @paul121: https://www.drupal.org/project/drupal/issues/2339235#comment-15382708
Thanks!
There was a problem hiding this comment.
Dang. Now tests are failing. 🤔
There was 1 failure:
1) Drupal\Tests\farm_inventory\Functional\InventoryTest::testApiInventory
Failed asserting that an array is not empty.
/opt/drupal/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/opt/drupal/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/opt/drupal/web/profiles/farm/modules/core/inventory/tests/src/Functional/InventoryTest.php:111
/opt/drupal/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
|
Huh. My test passed locally. But I'm running PostgreSQL and the failure was on SQLite3... 🤔 |
|
Huh, I think I saw this same error when I first made this PR but re-ran tests and it passed.. maybe there is a new race condition of some kind. Not sure. |
|
Wow I think you're right @paul121. I ran tests 4 times, and it failed 3 times, but just now it passed once. So that suggests it is not 10.2.1 that's causing the problem. Huh. Well I guess we can merge this and tag 3.0.0 after all! We can figure out the test issue as a follow up... |
Updated a Drupal core patch 2339235 and got tests to pass, but have not tested this locally.
10.2.0 release notes: https://www.drupal.org/project/drupal/releases/10.2.0
I don't think there are any major changes to be worried about here....
This could potentially affect some UI/CSS changes we have made, but seems unlikely.