Single Dockerfile using multi-stages for production and dev image #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change versions, add common paths
AlMaVizca
force-pushed
the
docker-multi-stage
branch
2 times, most recently
from
272bd3c
to
f58b884
Compare
Fix version replacement Add sources only on the final image
AlMaVizca
force-pushed
the
docker-multi-stage
branch
3 times, most recently
from
dec9bc8
to
0070e8c
Compare
AlMaVizca
force-pushed
the
docker-multi-stage
branch
from
0070e8c
to
3498a24
Compare
Replacing paths with variables to avoid mistakes. To run tests on the container, the entrypoint is checking /opt/drupal to later copy the sources. Running tests against /var/farmos, reduces that time
|
@AlMaVizca Hmm it looks like these test failures are specific to this PR. They aren't happening on the 3.x branch currently: https://github.com/farmOS/farmOS/actions Maybe the easiest thing to do is create a new testing branch (separate from this PR branch) and push one commit at a time to your fork to see which change causes the issue. This also helps to ensure each commit is a self-container non-breaking change. |
|
FYI: If you prefix your branch name with |
|
Closed in favor of #751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is reorganizing the instructions to get advantage of the Docker cache, and handle a single file for images