Update ol-geocoder to ^4.3 to fix search results #197 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstenta
approved these changes
Oct 2, 2023
paul121
force-pushed
the
2.x-geocoder-search
branch
from
0a5f470
to
49ff7b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating ol-geocoder solves the issue and geocoding search works again. There are a couple changes that come with this:
All other existing functionality continues to work the same: click on a result, and map zooms to that location.
Also want to note that the ol-geocoder library has transition maintainers in the past month and many of these changes have been implemented by the new maintainer. Here is the old repo link that redirects to the new: https://github.com/jonataswalker/ol-geocoder