Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farmOS 3.1.0 + Inventory quick form blog posts #25

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

mstenta
Copy link
Member

@mstenta mstenta commented Feb 5, 2024

Draft blog post announcing the release of farmOS 3.1.0 with summary of highlights, and a dedicated blog post for the new Inventory quick form.

The Inventory quick form post is largely copied and modified from the Movement quick form post: https://farmos.org/blog/2023/movement-quick-form/

Open to feedback/suggestions/word-smithing on the 3.1.0 post! I didn't give it a lot of time. The hope is that we can send this out as a first farmOS community newsletter, too, so we may want to add more to it with that in mind.

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for farmos-community-blog-preview ready!

Name Link
🔨 Latest commit 7d4bd5f
🔍 Latest deploy log https://app.netlify.com/sites/farmos-community-blog-preview/deploys/65c3ec9493b3a600080d12e9
😎 Deploy Preview https://deploy-preview-25--farmos-community-blog-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

botlfarm
botlfarm previously approved these changes Feb 5, 2024
Copy link
Collaborator

@botlfarm botlfarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good the me. 👍

asset inventory levels. Just select the asset you want to adjust and enter the
quantity (as a "reset", "increment", or "decrement")! There are some more
advanced options too, which are described in a dedicated post:
[Inventory Quick Form](inventory-quick-form)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link doesn't work, on deploy preview it points to /blog/inventory-quick-form but the post is at /blog/2024/inventory-quick-form

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm I can't seem to get this to work right. :-(

I tried changing it to /blog/2024/inventory-quick-form but that resulted in a link to /blog/blog/2024/inventory-quick-form.

I also tried ./inventory-quick-form (in case the ./ was helpful) but that had the same effect as the original issue (link to /blog/inventory-quick-form.

So it seems we may have a bug in the farmOS.org codebase's link generator, but only for blog posts? 🤔

Bummer. Well for the sake of this PR, I suppose we should just decide how it should work in blog posts. I think relative linking makes sense, right? So then we just need to figure out why it isn't being generated correctly in farmOS.org's code.

Alternatively, I could change it to an absolute link to https://farmOS.org/blog/2024/inventory-quick-form, but that means the preview wouldn't work, and it feels like it could cause future issues if we ever move things around.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just noticed (relatedly) that the second link in this 3.0.0 post is broken in the same way on the live site: https://farmos.org/blog/2024/farmOS-3.0.0/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using post slugs instead of folder names in relative links seems to generate working links:
wotnak@e689094
https://deploy-preview-6--wotnak-farmos-blog-preview.netlify.app/blog/2024/farmOS-3.1.0/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good find @wotnak! Thanks! I included your commit in the PR. I'll make note of that in farmOS/farmOS.org#90 too.

paul121
paul121 previously approved these changes Feb 6, 2024
Copy link
Member

@paul121 paul121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstenta mstenta merged commit 9cc0681 into farmOS:main Feb 7, 2024
4 checks passed
@mstenta
Copy link
Member Author

mstenta commented Feb 7, 2024

Merged! Thanks for the reviews @botlfarm @wotnak @paul121!

@mstenta mstenta deleted the farmOS-3.1.0 branch March 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants