Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World map #594

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

World map #594

wants to merge 11 commits into from

Conversation

twboc
Copy link

@twboc twboc commented Oct 19, 2019

No description provided.

@JanSimek
Copy link
Contributor

JanSimek commented May 5, 2020

Btw, README should mention that the sound directory must be copied from the Fallout 2 installation directory as well as master.dat and critter.dat. I couldn't figure out why 20car.acm and 23world.acm weren't being loaded from master.dat

const std::string sidePanelSprite = "art/intrface/wminfce2.frm";
const std::string fullPanelSprite = "art/intrface/wmapbox.frm";

std::vector<std::string> _worldMapTiles = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could use std::array here instead? Someone suggested that in one of my previous commits, so I am passing it on 😄

@falltergeist falltergeist deleted a comment from FakelsHub May 5, 2020
@falltergeist falltergeist deleted a comment from FakelsHub May 5, 2020
// Left button down
if (mouseEvent->name() == "mousedown" && mouseEvent->leftButton())
{
int mouseX = mouse->x();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mouseX and mouseY are only used as unsigned int below anyway, maybe statically cast them here already?

@667bdrm
Copy link
Contributor

667bdrm commented Jul 21, 2020

It could be great if broken mouse click handler could be restored. It will be useful for later functionality implementation. Also note, that 20car.acm sound used on world map when player have a car, when player don't have a car 23world.acm should be used as a music for world map.

Related issue: #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants