-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
World map #594
base: develop
Are you sure you want to change the base?
World map #594
Conversation
…ments passed to constructor
Btw, README should mention that the sound directory must be copied from the Fallout 2 installation directory as well as master.dat and critter.dat. I couldn't figure out why |
const std::string sidePanelSprite = "art/intrface/wminfce2.frm"; | ||
const std::string fullPanelSprite = "art/intrface/wmapbox.frm"; | ||
|
||
std::vector<std::string> _worldMapTiles = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you could use std::array
here instead? Someone suggested that in one of my previous commits, so I am passing it on 😄
// Left button down | ||
if (mouseEvent->name() == "mousedown" && mouseEvent->leftButton()) | ||
{ | ||
int mouseX = mouse->x(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mouseX
and mouseY
are only used as unsigned int
below anyway, maybe statically cast them here already?
It could be great if broken mouse click handler could be restored. It will be useful for later functionality implementation. Also note, that 20car.acm sound used on world map when player have a car, when player don't have a car 23world.acm should be used as a music for world map. Related issue: #392 |
No description provided.