Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE/CI] - remove auto downloads #1962

Merged
merged 6 commits into from
May 21, 2024
Merged

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 16, 2024

Motivation and Context

We've been wanting to remove the automatic downloads for awhile since they cause odd bugs unless the system paths are setup in a particular way. After #1961 these are also causing issues with the git checkout security. I'll remove them and add the necessary test assets to the unified download job.

How Has This Been Tested

CI

Types of changes

  • [Docs change] Addition or changes to the documentation

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 16, 2024
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3 aclegg3 merged commit 2c87031 into main May 21, 2024
4 checks passed
@aclegg3 aclegg3 deleted the alex-05_16-remove_auto_downloads branch May 21, 2024 15:19
0mdc pushed a commit that referenced this pull request May 23, 2024
* Disable new clone protection for git lfs

* remove auto asset downloader from the baseline tests

* add ycb to test asset download

* add rearrange dataset to asset download step

* turn off clone protection in hitl test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants