Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add navmesh offset #1785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add navmesh offset #1785

wants to merge 1 commit into from

Conversation

jimmytyyang
Copy link
Contributor

Motivation and Context

This passes navmesh information to the function that samples navigable points

How Has This Been Tested

Run interactive_play.py to verify its correctness.

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 1, 2024
0mdc
0mdc approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@ASzot ASzot Awaiting requested review from ASzot

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimmytyyang @0mdc @facebook-github-bot