Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device-mismatch fixes for running HITL tool with CUDA #1676

Open
wants to merge 2 commits into
base: eundersander/SIRo_hitl_Sep5_demo_refactored
Choose a base branch
from
Open

Device-mismatch fixes for running HITL tool with CUDA #1676

wants to merge 2 commits into from

Conversation

eundersander
Copy link
Contributor

Motivation and Context

Device-mismatch fixes for running HITL tool with CUDA

How Has This Been Tested

Local testing on Fedora laptop

Types of changes

PR into non-main branch

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 8, 2023
jimmytyyang
jimmytyyang approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! NIT: based on this PR, we need to modify the habitat-baseline code: habitat-baselines/habitat_baselines/rl/hrl/skills/place.py Not sure if there is a better way for only doing application level (i.e., sandbox tool) fixing. Thanks Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmytyyang jimmytyyang jimmytyyang approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eundersander @jimmytyyang @facebook-github-bot