Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for IAR compiler with attributes and intrinsics #4046

Merged
merged 2 commits into from
May 29, 2024

Conversation

josepho0918
Copy link
Contributor

This patch improves development experience and performance for projects using the IAR toolchain.

  • Utilize IAR compiler attributes
  • Optimized with IAR intrinsics

@Cyan4973
Copy link
Contributor

Sometimes I see __ICCARM__ being tested, and sometimes __IAR_SYSTEMS_ICC__.
Would you mind explaining the difference, and why sometimes one is better than the other ?

@josepho0918
Copy link
Contributor Author

Sometimes I see __ICCARM__ being tested, and sometimes __IAR_SYSTEMS_ICC__. Would you mind explaining the difference, and why sometimes one is better than the other ?

__IAR_SYSTEMS_ICC__ identifies the IAR compiler platform, while __ICCARM__ specifically designates the IAR compiler for Arm architecture. Since there're IAR versions for various architectures, such as RISC-V, __ICCARM__ is utilized for IAR intrinsics.

@Cyan4973
Copy link
Contributor

Quick question :
does it sound plausible to feature an __IAR_SYSTEMS_ICC__ compiler test during CI tests on Github Actions ?

If not, this is a "blind fix", and any future update could break compatibility is subtle ways, which would remain invisible.

@josepho0918
Copy link
Contributor Author

Quick question : does it sound plausible to feature an __IAR_SYSTEMS_ICC__ compiler test during CI tests on Github Actions ?

If not, this is a "blind fix", and any future update could break compatibility is subtle ways, which would remain invisible.

It will be fantastic to have CI tests for IAR. However, it's a paid tool.

@Cyan4973 Cyan4973 merged commit f70fb7c into facebook:dev May 29, 2024
94 checks passed
@Cyan4973 Cyan4973 self-assigned this May 29, 2024
@josepho0918 josepho0918 deleted the iar branch May 29, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants