Test PromoteL0() with no concurrent PromoteL0() in stress test #12648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
force-pushed
the
fix_promote_l0_stress
branch
from
9039e05
to
86da70e
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
force-pushed
the
fix_promote_l0_stress
branch
from
86da70e
to
a6d8390
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Will need to turn back on PromoteL0 |
hx235
changed the title
|
Close this since we plan to deprecate PromoteL0() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary:
If any file on L0 that PromoteL0() called on were moved or deleted concurrently by another PromoteL0(), it will result and propagate to users the corruption
Corruption: VersionBuilder: Cannot delete table file #13 from level 0 since it is on level 3to users. Such corruption will fail any subsequent writes. While it's debatable whether we should let such failure in PromoteL0() fail any subsequent writes, the easiest fix for now is to test PromoteL0() without any concurrent PromoteL0().Test:
CI that failed before this fix and pass after with equally frequent PromoteL0()