-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <named-color> to CSSParser #44623
Conversation
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
3f0d4b4
to
8d7f36c
Compare
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Base commit: 9dfcb9e |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
8d7f36c
to
4670f15
Compare
This pull request was exported from Phabricator. Differential Revision: D57553237 |
4670f15
to
7ce8780
Compare
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
7ce8780
to
9b72572
Compare
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
9b72572
to
2a0b139
Compare
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57553237
2a0b139
to
1d21ef1
Compare
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57553237
1d21ef1
to
58e5435
Compare
This pull request was exported from Phabricator. Differential Revision: D57553237 |
This pull request has been merged in 494c86e. |
This pull request was successfully merged by @jorge-cab in 494c86e. When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: facebook#44623 The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and directly return the RGBA Values Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57553237 fbshipit-source-id: 7b5bbaf77424cc4a4c833d107ef89601f9fcd9a9
Summary:
The syntax for is defined as (https://www.w3.org/TR/css-color-4/#color-syntax):
This diff implements in particular:
We create a map containing all hex value representations of each named color and convert the ident into hex.
Changelog: [Internal]
Differential Revision: D57553237