Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog updates #1171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changelog updates #1171

wants to merge 3 commits into from

Conversation

mikeday0
Copy link
Collaborator

Crispy friends: here's my humble attempt to catalog all the changes over the last year. You folks have been busy! Please review for wording and correctness. Thanks!

@JNechaevsky @rfomin @ceski-1 @SoDOOManiac @tomas7770 @SilverMiner @kitchen-ace

@kitchen-ace
Copy link
Collaborator

kitchen-ace commented Feb 21, 2024

Nice work, bookkeeping is never anyone's favourite job.

Can't speak to everything but anything with my name on it looks good, and I didn't spot any errors elsewhere at a glance.

I'll see if I can fix this today -- IMO no need to note it in a changelog since it's just a fix for a previous feature.
edit: Done!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@JNechaevsky
Copy link
Collaborator

Composing changelog is always most unexciting thing to do, thank you very much @mikeday0! I made few tiny corrections to make things a little bit fair. 🙂

One thing that disturbs be: I have Program:Win32/Wacapew.C!ml false alarm about compiled crispy-doom.exe in Microsoft Defender check on VirusTotal. It's slightly different from Woof, but have same roots of the problem. But! If crispy-doom.exe is processed via strip, then no false alarm is happening. Maybe this will helps somehow?

@rfomin
Copy link
Collaborator

rfomin commented Feb 22, 2024

If crispy-doom.exe is processed via strip, then no false alarm is happening. Maybe this will helps somehow?

We should run strip during packaging:

$(STRIP) $@/*.exe $@/*.dll

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@JNechaevsky
Copy link
Collaborator

Do we have an established release date yet? I have a small set of improvements for Hexen, collected while working on Inter, and definitely would like to contribute them to Crispy. Nothing too big, but I would like to ask for one or two extra evenings to don't do anything in rush.

@fabiangreffrath
Copy link
Owner

No, not in a rush at all. I'd like to get the Choco release through the door first, so we'd have a new clean base to biuld upon.

@mikeday0
Copy link
Collaborator Author

mikeday0 commented Mar 1, 2024

Shall I leave this open for additional items then?

@JNechaevsky
Copy link
Collaborator

From my side - nothing critical, just a small improvements, even not worth mentioning:

  • Raven: do not reset cursor position after deleting save game.
  • Hexen: smooth sky scrolling (finally I was able to make simple and better implementation).
  • Hexen: better line drawing in overlay mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants