doom: apply "specal treatment" to Nerve_demo.wad

[brianmwaters]

If you obtain NRFTL (No Rest for the Living) by extracting the wad from the Xbox Live Arcade release of Doom II for the Xbox 360 (which was the original release of NRFTL), you end up with a file called Nerve_demo.wad. Most other users seem to be using a file originally extracted from Doom 3: BFG Edition, which is called NERVE.WAD. Only the names differ; the file contents themselves are identical. (This is all explained on the Doom Wiki if you don't believe me.)

Because the developers of the XBLA release of Doom II did some things in a non-standard way, this WAD requires some quirks/fixups to play properly, particularly w/ regard to the music and title screen. Crispy applies these fixes whenever a WAD called NERVE.WAD has been loaded. This patch also applies the fixes if the WAD is called Nerve_demo.wad.

I adapted some code from D_LoadSigilWad to do this, and in general I think d_pwad.c could use some refactoring, especially now that I've added some more duplicated code. I'm happy to do that to get this change accepted. This here patch just takes the path of least resistance.

[fabiangreffrath]

Is it asked too much to just rename that file to nerve.wad?

[brianmwaters]

Is it asked too much to just rename that file to nerve.wad?

That's the workaround I used at first, of course, until I wrote this patch.

I will say, though, that when I first launched the game and saw that the title screen and music were different than on the Xbox 360, despite Crispy advertising native support for NRFTL, this led to several wasted hours of confusion on my part. (By the way, if you launch NRFTL via the BFG edition, it gets the title screen right, but also gets the music "wrong," which just added to the confusion for me.) It wasn't until I did some research and found out that some source ports ship fixes for NRFTL that things became more clear. I read the Crispy code and saw that the file needed to be named NERVE.WAD.

By adding support for Nerve_demo.wad, I was hoping to spare other users in the future from the same confusion.

[fabiangreffrath]

If you could change this to check if the file name starts with "nerve" then I will consider it.

[brianmwaters]

Revisiting this, I'm not sure this is the right approach; with zillions of community-made WAD's out there, it's not hard to imagine some might begin with the word "nerve".

This was admittedly a very pedantic patch from the beginning (with a simple workaround as you mentioned); feel free to close this out, and thanks for considering it.