Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minValue/maxValue intput/output types #462

Closed
wants to merge 3 commits into from

Conversation

Sec-ant
Copy link

@Sec-ant Sec-ant commented Feb 29, 2024

Before:
image

After:
image

Fixes #266.

@Sec-ant
Copy link
Author

Sec-ant commented Feb 29, 2024

I just noticed value, notValue and equal validations have similar type problems like this. I wonder if this fix is the right direction, so I can try to fix those validations, too. @fabian-hiller

Updated: I pushed a new commit to fix them all. Please review my code.

- Affected: `minValue`, `maxValue`, `value`, `notValue`, `equal`(deprecated)
- Docs content updated.
@fabian-hiller fabian-hiller self-assigned this Mar 1, 2024
@fabian-hiller fabian-hiller added enhancement New feature or request priority This has priority labels Mar 1, 2024
@fabian-hiller
Copy link
Owner

Thank you! I will review your changes in the next days.

@fabian-hiller
Copy link
Owner

I will first check to see if the issue #266 still exists after we change our API to this proposal: #463

@fabian-hiller
Copy link
Owner

I think this was solved with #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority This has priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type inference in v0.21.0
2 participants