Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export types from expo-modules-core in expo package #28994

Merged
merged 2 commits into from
May 21, 2024

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented May 20, 2024

Why

expo package should re-export some common and stable APIs from expo-modules-core that we would like to show in the docs.

How

This PR re-exports EventEmitter, SharedObject and NativeModule classes from expo-modules-core.

Additionally, I'm introducing expo/types import which exports these three classes but as types instead of values. They have the same names, so exporting them from the main entry point is a bit tricky. Docs data generation also needs these types to be exposed.

Test Plan

  • SDK checks are passing
  • Docs are looking good enough (except that EventEmitter methods are unnecessarily listed in its subclasses)

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 20, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 20, 2024

The Pull Request introduced fingerprint changes against the base commit: 8f4d915

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../node_modules/expo",
    "reasons": [
      "bareRncliAutolinking"
    ],
    "hash": "18e9627c693badbc6cf56b26da7e06a252c51259"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid",
      "expoConfigPlugins",
      "expoConfigPlugins"
    ],
    "hash": "665caada18b61900aef10fb3edfbd1cac3702d04"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "c7de58d4f06f68b8d7c862e884dbc6a7fcf057dc"
  }
]

Generated by PR labeler 🤖

@expo-bot
Copy link
Collaborator

expo-bot commented May 20, 2024

📘 Your docs preview website is ready!

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 20, 2024
@tsapeta tsapeta marked this pull request as ready for review May 20, 2024 20:48
@tsapeta tsapeta merged commit bdd562f into main May 21, 2024
27 of 28 checks passed
@tsapeta tsapeta deleted the @tsapeta/reexport-modules-core-types branch May 21, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants