Report ReferenceSchema Event only when it match the schema #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to report the ReferecenceSchema event only when the schema is matching against the event.
|
Hi! This change can break existing behaviour (so it can break other users' visitors), can't it? |
|
Yes, this change can break existing behaviour :( The issue, is that json-schema is reporting the schema referenced even if the schema is not maching. Should we move to use the same approach of Match/UnMatch event with the Referent event? So we can inform in the Listener if the Referenced Schema is matching or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to report the ReferecenceSchema event only when the schema is matching against the event.