Refactor JSON API into own Module #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON is widespread and many applications leverage it already. Adding support for Schemas to a existing Solution might cause some hindrance due to the various Json Implementations (e.g. Gson, org.json, jackson) currently existing. Relying on a specific JSON implementation requires consuming parties to choose between libraries that support their own library or write conversion code from and to a library of their choice. This work tries to introduce a new modular design, without breaking any existing code relying on org.json. After rewriting the Infrastructure it might be a good idea to remove some/all deprecation though. Signed-off-by: Bjoern Heinrichs <bjoern@heinrichs.pro>
|
Hello @BjoernAkAManf , Thank you for putting effort into this PR. This is the 3rd attempt (see #190 and #220 ) to abstract the library away from org.json. We should spend time on taking the best of all three and have a solid solution for the problem. |
|
I most certainly agree. For that we should define goals first. Such as backwards compatibility as a priority or not. I noticed many problems with the latter due to many public methods exposed, that some client might depend on. So it would be good idea to limit them in the future, define a deprecation strategy and remove / hide such methods. Edit: Also a huge thank you for this library. Integration was very easy in my products. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged as is and is simply a basic design that could be leveraged in the future. I did not document alot of the new functions, because most of them simply wrap the already existing methods / refactor them into new interfaces. This would allow to swap between implementations easily.
This PR is directly in contrast to #190 due to the nature of this PR. While i agree, that supporting Jackson is a good thing, i would kindly disagree, to simply switch the whole code base into a new model that is not backed by any standard (Obligatory XKCD).
See #37 #189 for more context to this issue.