Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jackson as the JSON parser instead of org.json #189

Closed
ramuramaiah opened this issue Jun 19, 2018 · 7 comments
Closed

jackson as the JSON parser instead of org.json #189

ramuramaiah opened this issue Jun 19, 2018 · 7 comments

Comments

@ramuramaiah
Copy link

Hi,
I have modified the original source code of everit JSON schema parser to make use of jackson as the underlying JSON schema parser instead of org.json due to the business unfriendly license of org.json JSON parser.
I have made sure the following

  • The original design and the interfaces remains the same. The modification is only minimal.
  • All tests pass.

Let me know if I can share the changes and anyone is interested to make use of the same.
I am not sure about the copyrights etc. Hence I don't want to create a new GitHub project.

@erosb
Copy link
Contributor

erosb commented Jun 19, 2018

Hello @ramuramaiah , thank you for your efforts. This sounds promising, though I doubt it doesn't break any of the method signatures. Please create a fork of this project and share your changes in the form of a pull request. If you are not familiar with this workflow please refer to the GitHub documentation .

Making the json implementation replaceable has been under consideration for quite some while, but for me it doesn't look simple to replace the data model of the library in a backward-compatible way (which is a top-priority for the project). I'm curious about what you figured out.

Thanks.

@ramuramaiah
Copy link
Author

erosb,
Do I need some permissions to create a pull request for this project? The "create pull request" tab is disabled for me. I did login with my GitHub account.

@erosb
Copy link
Contributor

erosb commented Jun 19, 2018

You have to go to the GH page of your fork and find the Pull Request button there.

@ramuramaiah
Copy link
Author

erosb,
I have created a new pull request and you should be able to see it.
Following is the heading of the pull request

Replaced the org.json JSON parser with jackson JSON parser #190
<<
Please review and let me know your opinion.

@Yobikap
Copy link

Yobikap commented Dec 9, 2021

@ramuramaiah Is it possible to create a fork and implement your changes into that fork?

I also need this functionality as for now it is giving me a lot of headache to let the code work with existing POJO's and with Jackson

@erosb
Copy link
Contributor

erosb commented Dec 9, 2021

@Yobikap if you need jackson then TBH I would look for an other json schema library. There are a few options nowadays.

@erosb
Copy link
Contributor

erosb commented May 2, 2023

Hello, this project is now superseded by erosb/json-sKema which has its own json parser and doesn't have such library dependency. Closing this issue.

@erosb erosb closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants