-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 Support (#752) #765
base: develop
Are you sure you want to change the base?
Conversation
* Ignore .vscode * Python 3.12 Support * Change base python to 3.12 and pin pydantic to V1 * all tests passed * ci: change default python to 3.12 * remove legacy python versions * annotate pydantic models for tests
👋 Can you estimate when this PR will be finished? |
@rmk135 please, can you give us (community) some expectations about this pr? |
Maybe temporarily merge PR despite of some failed unit tests... |
@rmk135 can you please look into this PR when you have the chance? This package is at least used by 2.5k repositories (based on GitHub stats) and Python 3.12 has been released 2 months ago. All the projects that are using this package are being blocked from updating to Python 3.12. If you no longer have the capacity to maintain this project, would you be able to look for collaborators or transfer ownership to someone who can maintain it? @anton-petrov who is the maintainer of pyenv has offered to help maintain this project #688 (comment) Maybe you can work out something with them for the future of this project? |
As a temporary solution, anyone can install directly from the repository https://github.com/anton-petrov/python-dependency-injector or create their own fork. |
hello @rmk135 , is there any update about this PR. |
@anton-petrov |
Yeah plz do it if possible. Will help me a lot |
@rmk135 any update on this PR? |
@rmk135 you're alive? |
@rmk135 please give a reply. I need to upgrade our project to python 3.12 . it is now mandatory for us but due to this package can not upgrade . and it will be difficult for us to use others alternative packages cause in that case need to change lot of things . Please give some update . |
@rmk135 has no Github activity over the last two months. They are probably not just ignoring the requests here but are unable to check Github for whatever reasons. @StummeJ as a previous contributor of this repo, are you able to help merging this PR? Or advice on who might be able to help? |
As mentioned in the issues referenced here: it seems @rmk135 does not have a lot of time available to implement new features on the repo. He even mentioned that he's looking for an additional/new maintainer link. @anton-petrov offered his help, but not sure if that went any further than the offer. |
Unfortunately, this is the main problem - he himself has already stopped working on the library, but also he has not handed it over to anyone for further maintenance. |
I've actually switched to using Neoteroi's Rodi (along with their configuration manager). They'er actively building a web framework for python so it's still maintained (be it a bit slow (days) sometimes) Rodi and essentials-configuration was inspired by dotnet's dependency injection and config manager. |
First, python 3.12 support was initiated by @rmk135 and then he disappeared. Then @anton-petrov started developing of his fork and disappeared too. Well, now it's my time to take that risk. I took Anton's PR and made some improvements to the point where it become possible to build and publish to PyPI. I didn't bother figuring out how to build packages for old interpreters and dropped this code.
UPD: |
this is sad :/ I guess this is end for this library in production environments. |
- Drop python image version to 3.9.* due to dependency python support limitation: see ets-labs/python-dependency-injector#765
- Drop python image version to 3.9.* due to dependency python support limitation: see ets-labs/python-dependency-injector#765
Oh, is it really no more update...? 😢 |
Hello, I wrote small DI framework as a replacement for dependency-injector with minimal changes https://github.com/modern-python/that-depends No wiring and Python 3.12 is supported. |
Ignore .vscode
Python 3.12 Support
Change base python to 3.12 and pin pydantic to V1
all tests passed
ci: change default python to 3.12
remove legacy python versions
annotate pydantic models for tests