mod: construction sound no longer loops, fixes #2429

[nanocirs]

Solved the issue where construction sound looped every 4s. Construction sound is now only triggered when starting to build.

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Vorschreibung]

Heya, I'm not a regular contrib here, so take my notes with a grain of salt - tried your patch and can confirm that this works. Plays sound only once the construction starts.

Even if you die and come back, as long as it is still partially constructed, will also not play the sound again until it's either destroyed or construction aborted due to idleness.

Suggest to add a comment above the conditional that mentions that constructible->s.angles2[0] here is (AFAIS) the health of the constructible (grep for addhealth) - and/or to mention something like // play construction sound only at the start of construction.

I have checked with 2.60b and it seems to behave the exact same way now. 🤘 😊