-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linea_estimateGas #4597
base: main
Are you sure you want to change the base?
Conversation
Hey @ricmoo, |
Hi @ricmoo, I hope you're doing well. I wanted to kindly follow up on our PR regarding the gas price optimization for Linea users. We believe this feature could significantly benefit ethers.js users by facilitating cheaper gas prices. If there's any additional information or adjustments needed to streamline the review process, please let us know. We're eager to contribute and make any necessary changes to align with the project's standards. Thank you for your time and the amazing work you do with ethers.js. Looking forward to your feedback |
Heya! I can review it this week. I have a minor version going out tonight, but will look into this to see if it needs a minor version bump or not. |
This change looks like it requires significant API changes (it is adding a parameter to Can you also not include the build files? It makes it much harder to compare the diff. Only changes to |
Hello @ricmoo i excluded the build files and added support pricing plugin to linea-sepolia |
Linea, a layer 2 blockchain, supports the Ethereum EIP-1559 gas price model, known for making transaction fees more predictable. Unlike the base Ethereum layer, Linea aims to offer a more stable and cost-effective approach to handling transaction fees. For detailed information, you can visit Linea's Gas Fees Documentation.
To further enhance the efficiency of transaction fee calculations, Linea has introduced a new RPC method designed to provide the best gas price estimates. This new method is documented in detail here.
The introduction of this new RPC method necessitates changes in how web3 libraries calculate gas prices. Traditionally, these libraries used the eth_gasPrice method. Linea's update shifts this approach to utilize the newly introduced linea_estimateGas method.
Detailed summary
linea_estimateGas
plugin to calculate accurate gas price on Linea networkgetFeeData
to pass the transaction data