Build out verkle trie processing #3430
Draft
+99
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electra.yaml
Outdated
| - el_type: ethereumjs | ||
| el_image: ethereumjs:local | ||
| cl_type: grandine | ||
| cl_image: ethpandaops/grandine:feature-electra |
There was a problem hiding this comment.
Doesn't seem like that should belong to this PR?
There was a problem hiding this comment.
It doesn't. Accidentally included and will remove.
| // Index of the child pointed by the next byte in the key | ||
| const childIndex = stem[this.depth] | ||
|
|
||
| const child = this.children[childIndex] | ||
|
|
||
| if (child instanceof LeafNode) { | ||
| // TODO: Understand the intent of what cowChild is suppoded to do |
There was a problem hiding this comment.
cow stands for "copy-on-write". As far as I recall cowChild is used as a record to mark the children that have been modified, in order to stack the commitment updates at the end since that is way more efficient.
|
|
||
| // TODO - Why is the leaf node set at depth + 2 instead of + 1)? |
There was a problem hiding this comment.
I think that this is because the leaf is inserted in the position of the suffix level commitment. So we have:
depth n : internal node:
depth n+1: the extension level commitment
depth n+2: the suffix level commitment
See this picture for how that corresponds to the structure:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP