Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten DB #2980

Open
wants to merge 134 commits into
base: master
Choose a base branch
from
Open

Flatten DB #2980

wants to merge 134 commits into from

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Aug 22, 2023

The aim of this change is to implement a flat database design for keeping state data in. This work will be integrated with the snap sync implementation for keeping snapshots of the latest 128 states. This work picks up where #780 left off. The goal is to first implement the StackTrie structure, then to implement the Snapshot and database wrapper necessary for data persistence.

@holgerd77
Copy link
Member

holgerd77 commented Aug 24, 2023

Side note: VM is definitely the wrong package, that's clear I guess, assuming a bit this is just for testing? Just to point out, so that this doesn't "settle at the wrong place" 😋, I know though that this is very very early.

@scorbajio scorbajio mentioned this pull request Aug 23, 2023
4 tasks
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: Patch coverage is 79.21348% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 87.39%. Comparing base (b8f5b6d) to head (1e6ca80).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.34% <ø> (ø)
blockchain 91.61% <ø> (ø)
client 84.62% <100.00%> (-0.11%) ⬇️
common 98.25% <ø> (ø)
devp2p 82.12% <ø> (ø)
ethash ∅ <ø> (∅)
evm 74.33% <ø> (ø)
genesis 99.98% <ø> (ø)
rlp ?
statemanager ?
trie 89.83% <95.70%> (+0.59%) ⬆️
tx 95.45% <ø> (ø)
util 84.82% <27.90%> (-4.32%) ⬇️
vm 80.17% <66.66%> (-0.04%) ⬇️
wallet 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants